FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
67 23 0 0

Files

Class Bugs
org.universAAL.ui.dm.DialogManagerImpl 2
org.universAAL.ui.dm.UserDialogManager$AutoSaverTask 1
org.universAAL.ui.dm.adapters.AdapterUserImpairments 1
org.universAAL.ui.dm.osgi.DialogManagerActivator 1
org.universAAL.ui.dm.ui.preferences.buffer.UIPreferencesBufferNoUpdate 1
org.universAAL.ui.dm.ui.preferences.buffer.UIPreferencesBufferSubscriptor 1
org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofileHelper 2
org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofilePrerequisitesHelper 3
org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesDialogBuilder 5
org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesSCallee 2
org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesUICaller 1
org.universAAL.ui.dm.userInteraction.mainMenu.file.FileMainMenuProvider 1
org.universAAL.ui.dm.userInteraction.mainMenu.file.MenuNode$NodeChildren 1
org.universAAL.ui.dm.userInteraction.mainMenu.profilable.SCallee 1

org.universAAL.ui.dm.DialogManagerImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.universAAL.middleware.rdf.Resource to org.universAAL.ontology.profile.User in org.universAAL.ui.dm.DialogManagerImpl.userLogIn(Resource, AbsLocation) STYLE BC_UNCONFIRMED_CAST 213 Medium
Incorrect lazy initialization of static field org.universAAL.ui.dm.DialogManagerImpl.singleton in org.universAAL.ui.dm.DialogManagerImpl.stopDM() MT_CORRECTNESS LI_LAZY_INIT_STATIC 408 Medium

org.universAAL.ui.dm.UserDialogManager$AutoSaverTask

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in new org.universAAL.ui.dm.UserDialogManager$AutoSaverTask(UserDialogManager) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 911 Medium

org.universAAL.ui.dm.adapters.AdapterUserImpairments

Bug Category Details Line Priority
new org.universAAL.ui.dm.adapters.AdapterUserImpairments(AccessImpairment[]) may expose internal representation by storing an externally mutable object into AdapterUserImpairments.accessImpairments MALICIOUS_CODE EI_EXPOSE_REP2 39 Medium

org.universAAL.ui.dm.osgi.DialogManagerActivator

Bug Category Details Line Priority
Write to static field org.universAAL.ui.dm.osgi.DialogManagerActivator.mContext from instance method org.universAAL.ui.dm.osgi.DialogManagerActivator.start(ModuleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 39 High

org.universAAL.ui.dm.ui.preferences.buffer.UIPreferencesBufferNoUpdate

Bug Category Details Line Priority
Redundant nullcheck of uiPSP, which is known to be non-null in org.universAAL.ui.dm.ui.preferences.buffer.UIPreferencesBufferNoUpdate.addUser(User) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 63 Medium

org.universAAL.ui.dm.ui.preferences.buffer.UIPreferencesBufferSubscriptor

Bug Category Details Line Priority
Redundant nullcheck of uiPSP, which is known to be non-null in org.universAAL.ui.dm.ui.preferences.buffer.UIPreferencesBufferSubscriptor.addUser(User) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 81 Medium

org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofileHelper

Bug Category Details Line Priority
Write to static field org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofileHelper.caller from instance method new org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofileHelper(ModuleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 59 High
Write to static field org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofileHelper.mcontext from instance method new org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofileHelper(ModuleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 58 High

org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofilePrerequisitesHelper

Bug Category Details Line Priority
org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofilePrerequisitesHelper.mc should be package protected MALICIOUS_CODE MS_PKGPROTECT 45 Medium
org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofilePrerequisitesHelper.logUsers(User[]) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 341 Medium
Write to static field org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofilePrerequisitesHelper.mc from instance method new org.universAAL.ui.dm.ui.preferences.caller.helpers.UIPreferencesSubprofilePrerequisitesHelper(ModuleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 55 High

org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesDialogBuilder

Bug Category Details Line Priority
Return value of org.universAAL.ontology.ui.preferences.UIPreferencesSubProfile.getAccessMode() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 957 Medium
Return value of org.universAAL.ontology.ui.preferences.UIPreferencesSubProfile.getAlertPreferences() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 915 Medium
Return value of org.universAAL.ontology.ui.preferences.UIPreferencesSubProfile.getAudioPreferences() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 767 Medium
Return value of org.universAAL.ontology.ui.preferences.UIPreferencesSubProfile.getSystemMenuPreferences() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 279 Medium
Return value of org.universAAL.ontology.ui.preferences.UIPreferencesSubProfile.getVisualPreferences() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 438 Medium

org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesSCallee

Bug Category Details Line Priority
Write to static field org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesSCallee.mcontext from instance method new org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesSCallee(ModuleContext, UIPreferencesUICaller) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 51 Medium
Write to static field org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesSCallee.uiPreferencesUICaller from instance method new org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesSCallee(ModuleContext, UIPreferencesUICaller) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 52 Medium

org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesUICaller

Bug Category Details Line Priority
Write to static field org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesUICaller.mcontext from instance method new org.universAAL.ui.dm.ui.preferences.editor.UIPreferencesUICaller(ModuleContext, IUIPreferencesBuffer) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 63 High

org.universAAL.ui.dm.userInteraction.mainMenu.file.FileMainMenuProvider

Bug Category Details Line Priority
Redundant nullcheck of f, which is known to be non-null in org.universAAL.ui.dm.userInteraction.mainMenu.file.FileMainMenuProvider.getMainMenu(Resource, AbsLocation, Form) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 122 Medium

org.universAAL.ui.dm.userInteraction.mainMenu.file.MenuNode$NodeChildren

Bug Category Details Line Priority
org.universAAL.ui.dm.userInteraction.mainMenu.file.MenuNode$NodeChildren.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 54 Medium

org.universAAL.ui.dm.userInteraction.mainMenu.profilable.SCallee

Bug Category Details Line Priority
Redundant nullcheck of dm, which is known to be non-null in org.universAAL.ui.dm.userInteraction.mainMenu.profilable.SCallee.refreshMainMenu(String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 262 Medium