FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
6 11 0 0

Files

Class Bugs
org.universAAL.samples.lighting.uiclient.LightingConsumer 9
org.universAAL.samples.lighting.uiclient.ServiceProvider 1
org.universAAL.samples.lighting.uiclient.SharedResources 1

org.universAAL.samples.lighting.uiclient.LightingConsumer

Bug Category Details Line Priority
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.uiclient.LightingConsumer.dimToValue(String, Integer), since all Integer are instances of Integer STYLE BC_VACUOUS_INSTANCEOF 279 Medium
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.uiclient.LightingConsumer.dimToValue(String, Integer), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 279 Medium
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.uiclient.LightingConsumer.turnOff(String), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 239 Medium
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.uiclient.LightingConsumer.turnOn(String), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 260 Medium
org.universAAL.samples.lighting.uiclient.LightingConsumer.turnOffRequest(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 97 Medium
org.universAAL.samples.lighting.uiclient.LightingConsumer.turnOnRequest(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 112 Medium
Incorrect lazy initialization and update of static field org.universAAL.samples.lighting.uiclient.LightingConsumer.allLightSources in org.universAAL.samples.lighting.uiclient.LightingConsumer.getControlledLamps() MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 183 High
Public static org.universAAL.samples.lighting.uiclient.LightingConsumer.getControlledLamps() may expose internal representation by returning LightingConsumer.allLightSources MALICIOUS_CODE MS_EXPOSE_REP 232 Medium
Write to static field org.universAAL.samples.lighting.uiclient.LightingConsumer.caller from instance method new org.universAAL.samples.lighting.uiclient.LightingConsumer(ModuleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 70 Medium

org.universAAL.samples.lighting.uiclient.ServiceProvider

Bug Category Details Line Priority
org.universAAL.samples.lighting.uiclient.ServiceProvider.myProfile isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 41 High

org.universAAL.samples.lighting.uiclient.SharedResources

Bug Category Details Line Priority
org.universAAL.samples.lighting.uiclient.SharedResources.moduleContext isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL Medium