FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
9 15 0 0

Files

Class Bugs
org.universAAL.samples.lighting.client.Activator 1
org.universAAL.samples.lighting.client.LightClient 4
org.universAAL.samples.lighting.client.LightClient$5 2
org.universAAL.samples.lighting.client.LightingConsumer 8

org.universAAL.samples.lighting.client.Activator

Bug Category Details Line Priority
org.universAAL.samples.lighting.client.Activator.mc should be package protected MALICIOUS_CODE MS_PKGPROTECT Medium

org.universAAL.samples.lighting.client.LightClient

Bug Category Details Line Priority
Changes to logger could be lost in org.universAAL.samples.lighting.client.LightClient.<static initializer for LightClient>() EXPERIMENTAL LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE 66 High
Write to static field org.universAAL.samples.lighting.client.LightClient.jList1 from instance method org.universAAL.samples.lighting.client.LightClient.start() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 119 High
Write to static field org.universAAL.samples.lighting.client.LightClient.offButton from instance method org.universAAL.samples.lighting.client.LightClient.start() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 90 High
Write to static field org.universAAL.samples.lighting.client.LightClient.onButton from instance method org.universAAL.samples.lighting.client.LightClient.start() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 83 High

org.universAAL.samples.lighting.client.LightClient$5

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.universAAL.samples.lighting.client.LightClient$5.actionPerformed(ActionEvent) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 230 High
org.universAAL.samples.lighting.client.LightClient$5.actionPerformed(ActionEvent) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 231 Medium

org.universAAL.samples.lighting.client.LightingConsumer

Bug Category Details Line Priority
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.client.LightingConsumer.dimToValue(String, Integer), since all Integer are instances of Integer STYLE BC_VACUOUS_INSTANCEOF 234 Medium
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.client.LightingConsumer.dimToValue(String, Integer), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 234 Medium
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.client.LightingConsumer.turnOff(String), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 190 Medium
instanceof will always return true for all non-null values in org.universAAL.samples.lighting.client.LightingConsumer.turnOn(String), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 213 Medium
org.universAAL.samples.lighting.client.LightingConsumer.turnOffRequest(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 95 Medium
org.universAAL.samples.lighting.client.LightingConsumer.turnOnRequest(String) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 108 Medium
org.universAAL.samples.lighting.client.LightingConsumer.caller should be package protected MALICIOUS_CODE MS_PKGPROTECT Medium
Write to static field org.universAAL.samples.lighting.client.LightingConsumer.caller from instance method new org.universAAL.samples.lighting.client.LightingConsumer(ModuleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 67 Medium