FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
102 51 0 0

Files

Class Bugs
org.universAAL.ri.gateway.Exporter$NullConcurrentHashMap 1
org.universAAL.ri.gateway.Gateway 1
org.universAAL.ri.gateway.Session 2
org.universAAL.ri.gateway.Session$MessageQueueTask 1
org.universAAL.ri.gateway.Session$SessionStatusEvent 1
org.universAAL.ri.gateway.communication.cipher.LegacyBlowfishCipher 3
org.universAAL.ri.gateway.communication.cipher.StreamCipher 1
org.universAAL.ri.gateway.communicator.service.impl.AbstractLinkHandler 1
org.universAAL.ri.gateway.communicator.service.impl.ClientSocketCommunicationHandler$LinkHandler 1
org.universAAL.ri.gateway.communicator.service.impl.SessionManager 1
org.universAAL.ri.gateway.communicator.service.impl.SessionManager$SessionKey 1
org.universAAL.ri.gateway.communicator.service.impl.SessionManager$SessionStatus 1
org.universAAL.ri.gateway.configuration.ConfigurationFile 6
org.universAAL.ri.gateway.configuration.TurtleFileSecurityDefinition 2
org.universAAL.ri.gateway.configuration.UpdatedPropertiesFile 1
org.universAAL.ri.gateway.log.LoggerFactory$MyLogger 1
org.universAAL.ri.gateway.osgi.GatewayCommand 5
org.universAAL.ri.gateway.protocol.ImportMessage 2
org.universAAL.ri.gateway.protocol.Message 1
org.universAAL.ri.gateway.protocol.WrappedBusMessage 1
org.universAAL.ri.gateway.proxies.BusMemberReference 2
org.universAAL.ri.gateway.proxies.BusMemberReferenceTemporal 2
org.universAAL.ri.gateway.proxies.ReferencesManager 1
org.universAAL.ri.gateway.proxies.exporting.ProxySCaller 2
org.universAAL.ri.gateway.proxies.importing.ProxyContextSubscriber 4
org.universAAL.ri.gateway.proxies.importing.ProxySCallee 3
org.universAAL.ri.gateway.proxies.updating.RegistrationParametersAdder 1
org.universAAL.ri.gateway.proxies.updating.RegistrationParametersRemover 1
org.universAAL.ri.gateway.utils.CallSynchronizer 1

org.universAAL.ri.gateway.Exporter$NullConcurrentHashMap

Bug Category Details Line Priority
Using .equals to compare two org.universAAL.middleware.rdf.Resource[]'s, (equivalent to ==) in org.universAAL.ri.gateway.Exporter$NullConcurrentHashMap.getNullable(Object) CORRECTNESS EC_BAD_ARRAY_COMPARE 672 Medium

org.universAAL.ri.gateway.Gateway

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.universAAL.ri.gateway.Gateway.actualStart(ModuleContext) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 137 Medium

org.universAAL.ri.gateway.Session

Bug Category Details Line Priority
Inconsistent synchronization of org.universAAL.ri.gateway.Session.state; locked 50% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 462 Medium
org.universAAL.ri.gateway.Session.getStatus() is unsynchronized, org.universAAL.ri.gateway.Session.setStatus(SessionEvent$SessionStatus) is synchronized MT_CORRECTNESS UG_SYNC_SET_UNSYNC_GET 462 Medium

org.universAAL.ri.gateway.Session$MessageQueueTask

Bug Category Details Line Priority
Unconditional wait in org.universAAL.ri.gateway.Session$MessageQueueTask.run() MT_CORRECTNESS UW_UNCOND_WAIT 130 Medium

org.universAAL.ri.gateway.Session$SessionStatusEvent

Bug Category Details Line Priority
Should org.universAAL.ri.gateway.Session$SessionStatusEvent be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 71 Medium

org.universAAL.ri.gateway.communication.cipher.LegacyBlowfishCipher

Bug Category Details Line Priority
Found reliance on default encoding in org.universAAL.ri.gateway.communication.cipher.LegacyBlowfishCipher.setup(Properties): String.getBytes() I18N DM_DEFAULT_ENCODING 69 High
Inconsistent synchronization of org.universAAL.ri.gateway.communication.cipher.LegacyBlowfishCipher.cipher; locked 83% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 85 Medium
Redundant nullcheck of org.universAAL.ri.gateway.communication.cipher.LegacyBlowfishCipher.key, which is known to be non-null in org.universAAL.ri.gateway.communication.cipher.LegacyBlowfishCipher.setup(Properties) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 70 Medium

org.universAAL.ri.gateway.communication.cipher.StreamCipher

Bug Category Details Line Priority
Found reliance on default encoding in org.universAAL.ri.gateway.communication.cipher.StreamCipher.setup(Properties): String.getBytes() I18N DM_DEFAULT_ENCODING 64 High

org.universAAL.ri.gateway.communicator.service.impl.AbstractLinkHandler

Bug Category Details Line Priority
Call to String.equals(java.util.UUID) in org.universAAL.ri.gateway.communicator.service.impl.AbstractLinkHandler.reconnect() CORRECTNESS EC_UNRELATED_TYPES 195 High

org.universAAL.ri.gateway.communicator.service.impl.ClientSocketCommunicationHandler$LinkHandler

Bug Category Details Line Priority
Dead store to spaceManager in org.universAAL.ri.gateway.communicator.service.impl.ClientSocketCommunicationHandler$LinkHandler.handleSessionProtocol(Message) STYLE DLS_DEAD_LOCAL_STORE 248 Medium

org.universAAL.ri.gateway.communicator.service.impl.SessionManager

Bug Category Details Line Priority
org.universAAL.ri.gateway.communicator.service.impl.SessionManager.getSessionFromScopeId(String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 134 Medium

org.universAAL.ri.gateway.communicator.service.impl.SessionManager$SessionKey

Bug Category Details Line Priority
Should org.universAAL.ri.gateway.communicator.service.impl.SessionManager$SessionKey be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 61 Medium

org.universAAL.ri.gateway.communicator.service.impl.SessionManager$SessionStatus

Bug Category Details Line Priority
Should org.universAAL.ri.gateway.communicator.service.impl.SessionManager$SessionStatus be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 93 Medium

org.universAAL.ri.gateway.configuration.ConfigurationFile

Bug Category Details Line Priority
org.universAAL.ri.gateway.configuration.ConfigurationFile doesn't override java.util.Hashtable.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
Class org.universAAL.ri.gateway.configuration.ConfigurationFile defines non-transient non-serializable instance field cipher BAD_PRACTICE SE_BAD_FIELD Medium
org.universAAL.ri.gateway.configuration.NoSecurityDefinition stored into non-transient field ConfigurationFile.chainMNG BAD_PRACTICE SE_BAD_FIELD_STORE 64 Medium
org.universAAL.ri.gateway.configuration.TurtleFileSecurityDefinition stored into non-transient field ConfigurationFile.chainMNG BAD_PRACTICE SE_BAD_FIELD_STORE 70 Medium
org.universAAL.ri.gateway.operations.DenyDefault stored into non-transient field ConfigurationFile.chainMNG BAD_PRACTICE SE_BAD_FIELD_STORE 80 Medium
org.universAAL.ri.gateway.operations.DenyDefault stored into non-transient field ConfigurationFile.chainMNG BAD_PRACTICE SE_BAD_FIELD_STORE 87 Medium

org.universAAL.ri.gateway.configuration.TurtleFileSecurityDefinition

Bug Category Details Line Priority
Found reliance on default encoding in new org.universAAL.ri.gateway.configuration.TurtleFileSecurityDefinition(URL): new java.util.Scanner(InputStream) I18N DM_DEFAULT_ENCODING 61 High
new RuntimeException(String) not thrown in new org.universAAL.ri.gateway.configuration.TurtleFileSecurityDefinition(URL) CORRECTNESS RV_EXCEPTION_NOT_THROWN 66 High

org.universAAL.ri.gateway.configuration.UpdatedPropertiesFile

Bug Category Details Line Priority
org.universAAL.ri.gateway.configuration.UpdatedPropertiesFile.storeProperties() may fail to clean up java.io.OutputStream on checked exception EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE 132 Medium

org.universAAL.ri.gateway.log.LoggerFactory$MyLogger

Bug Category Details Line Priority
Should org.universAAL.ri.gateway.log.LoggerFactory$MyLogger be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 43 Medium

org.universAAL.ri.gateway.osgi.GatewayCommand

Bug Category Details Line Priority
Redundant nullcheck of scope, which is known to be non-null in org.universAAL.ri.gateway.osgi.GatewayCommand.doExecute() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 93 Medium
Format string should use %n rather than \n in org.universAAL.ri.gateway.osgi.GatewayCommand.doExecute() BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 67 Medium
Format string should use %n rather than \n in org.universAAL.ri.gateway.osgi.GatewayCommand.doExecute() BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 97 Medium
Format string should use %n rather than \n in org.universAAL.ri.gateway.osgi.GatewayCommand.doExecute() BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 63 Medium
Format string should use %n rather than \n in org.universAAL.ri.gateway.osgi.GatewayCommand.doExecute() BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 75 Medium

org.universAAL.ri.gateway.protocol.ImportMessage

Bug Category Details Line Priority
org.universAAL.ri.gateway.protocol.ImportMessage.getParameters() may expose internal representation by returning ImportMessage.parameters MALICIOUS_CODE EI_EXPOSE_REP 126 Medium
Inconsistent synchronization of org.universAAL.ri.gateway.protocol.ImportMessage.serializedParameters; locked 50% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 115 Medium

org.universAAL.ri.gateway.protocol.Message

Bug Category Details Line Priority
Write to static field org.universAAL.ri.gateway.protocol.Message.currentSequence from instance method new org.universAAL.ri.gateway.protocol.Message() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 61 Medium

org.universAAL.ri.gateway.protocol.WrappedBusMessage

Bug Category Details Line Priority
Possible null pointer dereference of WrappedBusMessage.content in org.universAAL.ri.gateway.protocol.WrappedBusMessage.equals(Object) CORRECTNESS NP_NULL_ON_SOME_PATH 96 Medium

org.universAAL.ri.gateway.proxies.BusMemberReference

Bug Category Details Line Priority
org.universAAL.ri.gateway.proxies.BusMemberReference defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 99 High
Class org.universAAL.ri.gateway.proxies.BusMemberReference defines non-transient non-serializable instance field sender BAD_PRACTICE SE_BAD_FIELD High

org.universAAL.ri.gateway.proxies.BusMemberReferenceTemporal

Bug Category Details Line Priority
org.universAAL.ri.gateway.proxies.BusMemberReferenceTemporal doesn't override BusMemberReference.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
Class org.universAAL.ri.gateway.proxies.BusMemberReferenceTemporal defines non-transient non-serializable instance field mq BAD_PRACTICE SE_BAD_FIELD Medium

org.universAAL.ri.gateway.proxies.ReferencesManager

Bug Category Details Line Priority
org.universAAL.ri.gateway.proxies.BusMemberReference doesn't define a hashCode() method but is used in a hashed data structure in org.universAAL.ri.gateway.proxies.ReferencesManager.removeRemoteProxyReference(BusMemberReference) CORRECTNESS HE_USE_OF_UNHASHABLE_CLASS 67 Medium

org.universAAL.ri.gateway.proxies.exporting.ProxySCaller

Bug Category Details Line Priority
org.universAAL.ri.gateway.proxies.exporting.ProxySCaller.getSubscriptionParameters() may expose internal representation by returning ProxySCaller.currentRegParam MALICIOUS_CODE EI_EXPOSE_REP 102 Medium
new org.universAAL.ri.gateway.proxies.exporting.ProxySCaller(ModuleContext, ServiceProfile[], String) may expose internal representation by storing an externally mutable object into ProxySCaller.currentRegParam MALICIOUS_CODE EI_EXPOSE_REP2 71 Medium

org.universAAL.ri.gateway.proxies.importing.ProxyContextSubscriber

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.universAAL.middleware.rdf.Resource[] to org.universAAL.middleware.context.ContextEventPattern[] in org.universAAL.ri.gateway.proxies.importing.ProxyContextSubscriber.addSubscriptionParameters(Resource[]) STYLE BC_UNCONFIRMED_CAST 110 Medium
Unchecked/unconfirmed cast from org.universAAL.middleware.rdf.Resource[] to org.universAAL.middleware.context.ContextEventPattern[] in org.universAAL.ri.gateway.proxies.importing.ProxyContextSubscriber.removeSubscriptionParameters(Resource[]) STYLE BC_UNCONFIRMED_CAST 118 Medium
org.universAAL.ri.gateway.proxies.importing.ProxyContextSubscriber.getSubscriptionParameters() may expose internal representation by returning ProxyContextSubscriber.currentRegParam MALICIOUS_CODE EI_EXPOSE_REP 88 Medium
new org.universAAL.ri.gateway.proxies.importing.ProxyContextSubscriber(ModuleContext, ContextEventPattern[]) may expose internal representation by storing an externally mutable object into ProxyContextSubscriber.currentRegParam MALICIOUS_CODE EI_EXPOSE_REP2 57 Medium

org.universAAL.ri.gateway.proxies.importing.ProxySCallee

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.universAAL.middleware.rdf.Resource[] to org.universAAL.middleware.service.owls.profile.ServiceProfile[] in org.universAAL.ri.gateway.proxies.importing.ProxySCallee.addSubscriptionParameters(Resource[]) STYLE BC_UNCONFIRMED_CAST 205 Medium
Unchecked/unconfirmed cast from org.universAAL.middleware.rdf.Resource[] to org.universAAL.middleware.service.owls.profile.ServiceProfile[] in org.universAAL.ri.gateway.proxies.importing.ProxySCallee.removeSubscriptionParameters(Resource[]) STYLE BC_UNCONFIRMED_CAST 213 Medium
org.universAAL.ri.gateway.proxies.importing.ProxySCallee.getSubscriptionParameters() may expose internal representation by returning ProxySCallee.currentRegParam MALICIOUS_CODE EI_EXPOSE_REP 184 Medium

org.universAAL.ri.gateway.proxies.updating.RegistrationParametersAdder

Bug Category Details Line Priority
new org.universAAL.ri.gateway.proxies.updating.RegistrationParametersAdder(Resource[]) may expose internal representation by storing an externally mutable object into RegistrationParametersAdder.nParams MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium

org.universAAL.ri.gateway.proxies.updating.RegistrationParametersRemover

Bug Category Details Line Priority
new org.universAAL.ri.gateway.proxies.updating.RegistrationParametersRemover(Resource[]) may expose internal representation by storing an externally mutable object into RegistrationParametersRemover.nParams MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium

org.universAAL.ri.gateway.utils.CallSynchronizer

Bug Category Details Line Priority