The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new ch.ethz.iks.slp.ServiceType(String) invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ServiceURL.protocol in ch.ethz.iks.slp.ServiceURL.equals(Object) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 212 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in ch.ethz.iks.slp.impl.AuthenticatedURL.getAuthData(String, int): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 121 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in ch.ethz.iks.slp.impl.AuthenticationBlock.getLength(): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 199 | High |
| Found reliance on default encoding in ch.ethz.iks.slp.impl.AuthenticationBlock.parse(DataInputStream): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 248 | High |
| Found reliance on default encoding in ch.ethz.iks.slp.impl.AuthenticationBlock.write(DataOutputStream): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 214 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ch.ethz.iks.slp.impl.SLPConfiguration.processProperties(Properties) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 256 | Medium |
| new ch.ethz.iks.slp.impl.SLPConfiguration(File) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 198 | Medium |
| ch.ethz.iks.slp.impl.SLPConfiguration.getPrivateKey(String) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 488 | Medium |
| ch.ethz.iks.slp.impl.SLPConfiguration.getPublicKey(String) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 461 | Medium |
| new ch.ethz.iks.slp.impl.SLPConfiguration(File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 198 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ch.ethz.iks.slp.impl.SLPCore.handleMessage(SLPMessage) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 549 | Medium |
| ch.ethz.iks.slp.impl.SLPCore.multicastConvergence(RequestMessage) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 805 | Medium |
| Comparison of String objects using == or != in ch.ethz.iks.slp.impl.SLPCore.handleMessage(SLPMessage) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 494 | Medium |
| ch.ethz.iks.slp.impl.SLPCore.platform isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| Naked notify in ch.ethz.iks.slp.impl.SLPCore.handleMessage(SLPMessage) | MT_CORRECTNESS | NN_NAKED_NOTIFY | 530 | Medium |
| Useless object stored in variable addresses of method ch.ethz.iks.slp.impl.SLPCore.<static initializer for SLPCore>() | STYLE | UC_USELESS_OBJECT | 260 | Medium |
| Unwritten public or protected field: ch.ethz.iks.slp.impl.SLPCore.platform | STYLE | UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| ch.ethz.iks.slp.impl.SLPDaemonImpl.registerService(ServiceRegistration) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 125 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in new ch.ethz.iks.slp.impl.ServiceTypeRequest(DataInputStream): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 99 | High |
