The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.datarep.SharedResources.moduleContext isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | High | |
| Unwritten public or protected field: org.universAAL.middleware.datarep.SharedResources.moduleContext | STYLE | UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD | 244 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.universAAL.middleware.owl.ComparableIndividual defines equal(Object); should it be equals(Object)? | CORRECTNESS | NM_BAD_EQUAL | 142 | High |
| Check to see if return value of compareTo(Object) is equal to 1 | CORRECTNESS | RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE | 151 | Medium |
| Check to see if return value of compareTo(Object) is equal to -1 | CORRECTNESS | RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE | 175 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.owl.HasValueRestriction.checkValueLists(List, List, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 173 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.owl.MergedRestriction.getFromList(List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 487 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.universAAL.middleware.owl.ObjectProperty.inverseOf | PERFORMANCE | URF_UNREAD_FIELD | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Synchronization on Ontology.imports in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 250 | High |
| Synchronization on Ontology.ontClassInfoMap in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 400 | Medium |
| Synchronization on Ontology.rdfClassInfoMap in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 343 | Medium |
| Synchronization on Ontology.extendedOntClassInfoMap in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 434 | Medium |
| Load of known null value in org.universAAL.middleware.owl.Ontology.addImport(String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 239 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| OntClassInfo is incompatible with expected argument type String in org.universAAL.middleware.owl.OntologyManagement.unregister(ModuleContext, Ontology) | CORRECTNESS | GC_UNRELATED_TYPES | 650 | High |
| Synchronization on OntologyManagement.ontologies in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 335 | High |
| Synchronization on OntologyManagement.ontologies in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 655 | High |
| Synchronization on OntologyManagement.pendingOntologies in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 234 | Medium |
| Synchronization on OntologyManagement.pendingOntologies in futile attempt to guard it | MT_CORRECTNESS | ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD | 209 | Medium |
| Nullcheck of ontClassInfos at line 267 of value previously dereferenced in org.universAAL.middleware.owl.OntologyManagement.register(ModuleContext, Ontology) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 267 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.owl.TypeExpression.synchronize(HashMap, HashMap) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 451 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable propSetup of method org.universAAL.middleware.owl.generic.GenericOntology.create() | STYLE | UC_USELESS_OBJECT | 168 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.owl.util.OntologyTest.postTestClass(Ontology, OntClassInfo, HashMap) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 119 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.rdf.LangString.equals(Object) checks for operand being a String | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 629 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.universAAL.middleware.rdf.Property.equivalentProperties | PERFORMANCE | URF_UNREAD_FIELD | 66 | Medium |
| Unread public/protected field: org.universAAL.middleware.rdf.Property.info | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 167 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.rdf.Resource.deepCopy() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 508 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.rdf.TypeMapper.getDatatypeURI(Class) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 264 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.util.MatchLogEntry.getArgs() may expose internal representation by returning MatchLogEntry.args | MALICIOUS_CODE | EI_EXPOSE_REP | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.util.ResourceComparator.getDiffsAsString(Resource, Resource) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 274 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.universAAL.middleware.xsd.Base64Binary.getVal() may expose internal representation by returning Base64Binary.val | MALICIOUS_CODE | EI_EXPOSE_REP | 85 | Medium |
| new org.universAAL.middleware.xsd.Base64Binary(byte[]) may expose internal representation by storing an externally mutable object into Base64Binary.val | MALICIOUS_CODE | EI_EXPOSE_REP2 | 48 | Medium |
| org.universAAL.middleware.xsd.Base64Binary defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 103 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive new org.universAAL.middleware.xsd.NonNegativeInteger(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 51 | High |
| org.universAAL.middleware.xsd.NonNegativeInteger.equals(Object) checks for operand being a Integer | BAD_PRACTICE | EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS | 77 | High |
| org.universAAL.middleware.xsd.NonNegativeInteger defines equals and uses Object.hashCode() | BAD_PRACTICE | HE_EQUALS_USE_HASHCODE | 73 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.universAAL.middleware.xsd.util.Base64.decode(String, int): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 1320 | High |
| Found reliance on default encoding in org.universAAL.middleware.xsd.util.Base64.encodeBytes(byte[], int, int, int): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 900 | High |
| Found reliance on default encoding in org.universAAL.middleware.xsd.util.Base64.encodeObject(Serializable, int): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 739 | High |
