FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
61 34 0 0

Files

Class Bugs
org.universAAL.middleware.service.AggregationFunction 1
org.universAAL.middleware.service.CallStatus 2
org.universAAL.middleware.service.MultiServiceResponse 1
org.universAAL.middleware.service.ServiceCall 3
org.universAAL.middleware.service.ServiceCallee 1
org.universAAL.middleware.service.ServiceRequest 1
org.universAAL.middleware.service.ServiceResponse 1
org.universAAL.middleware.service.impl.ServiceBusImpl 5
org.universAAL.middleware.service.impl.ServiceMatcher 2
org.universAAL.middleware.service.impl.ServiceRealization 1
org.universAAL.middleware.service.impl.ServiceStrategy 5
org.universAAL.middleware.service.impl.ServiceStrategy$AvailabilitySubscription 1
org.universAAL.middleware.service.impl.ServiceStrategy$WaitingRequest 1
org.universAAL.middleware.service.owl.Service 2
org.universAAL.middleware.service.owls.process.OutputBinding 1
org.universAAL.middleware.service.owls.process.ProcessParameter 1
org.universAAL.middleware.service.owls.process.ProcessResult 1
org.universAAL.middleware.service.owls.profile.NumberOfSamples 2
org.universAAL.middleware.service.owls.profile.ResponseTimeInMilliseconds 2

org.universAAL.middleware.service.AggregationFunction

Bug Category Details Line Priority
org.universAAL.middleware.service.AggregationFunction doesn't override org.universAAL.middleware.rdf.Resource.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.universAAL.middleware.service.CallStatus

Bug Category Details Line Priority
org.universAAL.middleware.service.CallStatus doesn't override org.universAAL.middleware.rdf.Resource.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
org.universAAL.middleware.service.CallStatus.valueOf(String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 74 Medium

org.universAAL.middleware.service.MultiServiceResponse

Bug Category Details Line Priority
org.universAAL.middleware.service.MultiServiceResponse.getOutputsMap() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 136 Medium

org.universAAL.middleware.service.ServiceCall

Bug Category Details Line Priority
org.universAAL.middleware.service.ServiceCall.addNonSemanticInput(Hashtable) may expose internal representation by storing an externally mutable object into ServiceCall.nonSemanticInput MALICIOUS_CODE EI_EXPOSE_REP2 97 Medium
org.universAAL.middleware.service.ServiceCall doesn't override org.universAAL.middleware.rdf.Resource.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
org.universAAL.middleware.service.ServiceCall.toString() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 359 Medium

org.universAAL.middleware.service.ServiceCallee

Bug Category Details Line Priority
Redundant nullcheck of sr, which is known to be non-null in org.universAAL.middleware.service.ServiceCallee.handleRequest(BusMessage) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 207 Medium

org.universAAL.middleware.service.ServiceRequest

Bug Category Details Line Priority
org.universAAL.middleware.service.ServiceRequest.toString() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 531 Medium

org.universAAL.middleware.service.ServiceResponse

Bug Category Details Line Priority
org.universAAL.middleware.service.ServiceResponse.toString() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 338 Medium

org.universAAL.middleware.service.impl.ServiceBusImpl

Bug Category Details Line Priority
org.universAAL.middleware.service.impl.ServiceBusImpl.startModule(ModuleContext, Object[], Object[], Object[], Object[]) may expose internal static state by storing a mutable object into a static field org.universAAL.middleware.service.impl.ServiceBusImpl.busFetchParams MALICIOUS_CODE EI_EXPOSE_STATIC_REP2 112 Medium
org.universAAL.middleware.service.impl.ServiceBusImpl.startModule(ModuleContext, Object[], Object[], Object[], Object[]) may expose internal static state by storing a mutable object into a static field org.universAAL.middleware.service.impl.ServiceBusImpl.busInjectFetchParams MALICIOUS_CODE EI_EXPOSE_STATIC_REP2 113 Medium
org.universAAL.middleware.service.impl.ServiceBusImpl.startModule(ModuleContext, Object[], Object[], Object[], Object[]) may expose internal static state by storing a mutable object into a static field org.universAAL.middleware.service.impl.ServiceBusImpl.busInjectRemoveParams MALICIOUS_CODE EI_EXPOSE_STATIC_REP2 119 Medium
org.universAAL.middleware.service.impl.ServiceBusImpl.startModule(ModuleContext, Object[], Object[], Object[], Object[]) may expose internal static state by storing a mutable object into a static field org.universAAL.middleware.service.impl.ServiceBusImpl.busRemoveParams MALICIOUS_CODE EI_EXPOSE_STATIC_REP2 118 Medium
Incorrect lazy initialization of static field org.universAAL.middleware.service.impl.ServiceBusImpl.theServiceBus in org.universAAL.middleware.service.impl.ServiceBusImpl.stopModule() MT_CORRECTNESS LI_LAZY_INIT_STATIC 127 Medium

org.universAAL.middleware.service.impl.ServiceMatcher

Bug Category Details Line Priority
instanceof will always return true for all non-null values in org.universAAL.middleware.service.impl.ServiceMatcher.matchRestrictions(ServiceWrapper, ServiceWrapper, HashMap, Long), since all org.universAAL.middleware.owl.MergedRestriction are instances of org.universAAL.middleware.owl.MergedRestriction STYLE BC_VACUOUS_INSTANCEOF 191 Medium
org.universAAL.middleware.service.impl.ServiceMatcher.matches(ServiceWrapper, ServiceWrapper, HashMap, Long) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 73 Medium

org.universAAL.middleware.service.impl.ServiceRealization

Bug Category Details Line Priority
org.universAAL.middleware.service.impl.ServiceRealization.addAggregatedProperties(HashMap) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 95 Medium

org.universAAL.middleware.service.impl.ServiceStrategy

Bug Category Details Line Priority
instanceof will always return true for all non-null values in org.universAAL.middleware.service.impl.ServiceStrategy.callStartDialog(ArrayList, String, BusMessage), since all String are instances of String STYLE BC_VACUOUS_INSTANCEOF 511 Medium
Switch statement found in org.universAAL.middleware.service.impl.ServiceStrategy.sendServiceResponse(BusMessage) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 579 Medium
Useless object stored in variable nmsf of method org.universAAL.middleware.service.impl.ServiceStrategy.sendServiceResponse(BusMessage) STYLE UC_USELESS_OBJECT 570 Medium
Wait not in loop in org.universAAL.middleware.service.impl.ServiceStrategy.waitForCoordinatorToBeKnown() MT_CORRECTNESS WA_NOT_IN_LOOP 1856 Medium
org.universAAL.middleware.service.impl.ServiceStrategy.getOutputValue(Map, AggregatingFilter) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 925 Medium

org.universAAL.middleware.service.impl.ServiceStrategy$AvailabilitySubscription

Bug Category Details Line Priority
Should org.universAAL.middleware.service.impl.ServiceStrategy$AvailabilitySubscription be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 108 Medium

org.universAAL.middleware.service.impl.ServiceStrategy$WaitingRequest

Bug Category Details Line Priority
Should org.universAAL.middleware.service.impl.ServiceStrategy$WaitingRequest be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 115 Medium

org.universAAL.middleware.service.owl.Service

Bug Category Details Line Priority
org.universAAL.middleware.service.owl.Service.addInstanceLevelRestriction(MergedRestriction, String[]) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 184 Medium
org.universAAL.middleware.service.owl.Service.setProperty(String, Object) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 327 Medium

org.universAAL.middleware.service.owls.process.OutputBinding

Bug Category Details Line Priority
Redundant nullcheck of key, which is known to be non-null in org.universAAL.middleware.service.owls.process.OutputBinding.checkBinding(Object) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 85 High

org.universAAL.middleware.service.owls.process.ProcessParameter

Bug Category Details Line Priority
org.universAAL.middleware.service.owls.process.ProcessParameter.setCardinality(int, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 321 Medium

org.universAAL.middleware.service.owls.process.ProcessResult

Bug Category Details Line Priority
Possible null pointer dereference of value in org.universAAL.middleware.service.owls.process.ProcessResult.setProperty(String, Object) CORRECTNESS NP_NULL_ON_SOME_PATH 270 Medium

org.universAAL.middleware.service.owls.profile.NumberOfSamples

Bug Category Details Line Priority
new org.universAAL.middleware.service.owls.profile.NumberOfSamples(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 40 Medium
new org.universAAL.middleware.service.owls.profile.NumberOfSamples(String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 47 Medium

org.universAAL.middleware.service.owls.profile.ResponseTimeInMilliseconds

Bug Category Details Line Priority
new org.universAAL.middleware.service.owls.profile.ResponseTimeInMilliseconds(int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 40 Medium
new org.universAAL.middleware.service.owls.profile.ResponseTimeInMilliseconds(String, int) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 47 Medium