The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.lddi.zwave.exporter.Activator.context should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 36 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to dir1 in org.universAAL.lddi.zwave.exporter.Setup.getSetupFileName() | STYLE | DLS_DEAD_LOCAL_STORE | 38 | High |
Comparison of String objects using == or != in org.universAAL.lddi.zwave.exporter.Setup.getSetupFileName() | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 40 | High |
org.universAAL.lddi.zwave.exporter.Setup.getVeraAddress() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 57 | Medium |
org.universAAL.lddi.zwave.exporter.Setup.getVeraAddress() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 57 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.universAAL.lddi.zwave.exporter.PowerConsumption.PowerReader.publishEnergyConsumption(): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 62 | High |
Found reliance on default encoding in org.universAAL.lddi.zwave.exporter.PowerConsumption.PowerReader.publishEnergyConsumption(): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 59 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unread public/protected field: org.universAAL.lddi.zwave.exporter.Server.AbstractProtocolDecoder.listener | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 53 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServer.DEFAULT_TCP_BUFFERS_SIZE isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 39 | High |
Unread public/protected field: org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServer.listenPort | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 77 | Medium |
Unread public/protected field: org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServer.tcpBufferSizeIn | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 45 | Medium |
Unread public/protected field: org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServer.tcpBufferSizeOut | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 47 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to connectionInfo in org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServerXSocket.onConnectionTimeout(INonBlockingConnection) | STYLE | DLS_DEAD_LOCAL_STORE | 284 | Medium |
Dead store to connectionInfo in org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServerXSocket.onIdleTimeout(INonBlockingConnection) | STYLE | DLS_DEAD_LOCAL_STORE | 346 | Medium |
Changes to logger could be lost in new org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServerXSocket(ISocketServerProtocolDecoderFactory, int, SSLContext, int, int) | EXPERIMENTAL | LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE | 133 | High |
org.universAAL.lddi.zwave.exporter.Server.AbstractSocketServerXSocket.activateConnectionLogging should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 61 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Useless object stored in variable sb of method org.universAAL.lddi.zwave.exporter.Server.ConnectionDataHandler.errorDecoding(String) | STYLE | UC_USELESS_OBJECT | 281 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.lddi.zwave.exporter.Server.ConnectionLinker.addConnection(ISocketServerConnection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 86 | Medium |
org.universAAL.lddi.zwave.exporter.Server.ConnectionLinker.removeConnection(ISocketServerConnection) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 132 | Medium |