The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.universAAL.hw.exporter.zigbee.ha.Activator.setProperties(Properties): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 77 | High |
org.universAAL.hw.exporter.zigbee.ha.Activator.moduleContext isn't final and can't be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 40 | Medium |
org.universAAL.hw.exporter.zigbee.ha.Activator.getProperties() may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 101 | Medium |
org.universAAL.hw.exporter.zigbee.ha.Activator.setProperties(Properties) may fail to clean up java.io.Writer on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 77 | Medium |
Write to static field org.universAAL.hw.exporter.zigbee.ha.Activator.context from instance method org.universAAL.hw.exporter.zigbee.ha.Activator.start(BundleContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 47 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to finalValue in org.universAAL.hw.exporter.zigbee.ha.devices.IASZoneCallee.getValue() | STYLE | DLS_DEAD_LOCAL_STORE | 128 | Medium |
org.universAAL.hw.exporter.zigbee.ha.devices.IASZoneCallee.getValue() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 128 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to finalValue in org.universAAL.hw.exporter.zigbee.ha.devices.OccupancySensorCallee.getValue() | STYLE | DLS_DEAD_LOCAL_STORE | 118 | Medium |
org.universAAL.hw.exporter.zigbee.ha.devices.OccupancySensorCallee.getValue() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 118 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.OnOffLightCallee.executeGet() has Boolean return type and returns explicit null | BAD_PRACTICE | NP_BOOLEAN_RETURN_NULL | 196 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.PresenceDetectorCallee.getValue() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 110 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.DimmerLightListener.unregisterService() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 87 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
new org.universAAL.hw.exporter.zigbee.ha.devices.listeners.ExporterListener(BundleContext) synchronizes on updated field ExporterListener.discoveryLock | MT_CORRECTNESS | ML_SYNC_ON_UPDATED_FIELD | 52 | Medium |
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.ExporterListener.filter isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 46 | High |
Switch statement found in org.universAAL.hw.exporter.zigbee.ha.devices.listeners.ExporterListener.serviceChanged(ServiceEvent) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 71 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.IASZoneListener.unregisterService() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 76 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.OccupancySensorListener.unregisterService() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 76 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.OnOffLightListener.unregisterService() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 87 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.PresenceDetectorListener.unregisterService() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 86 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.universAAL.hw.exporter.zigbee.ha.devices.listeners.TemperatureSensorListener.unregisterService() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 87 | Medium |