FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
22 21 0 0

Files

Class Bugs
org.universAAL.lddi.fs20.connect.FHZ1000PC 4
org.universAAL.lddi.fs20.connect.FHZ1000PC$FHZ1000SerialDevice 2
org.universAAL.lddi.fs20.connect.FHZ1000PC$JD2XXFHZ1000Device 1
org.universAAL.lddi.fs20.connect.FS20Listener 6
org.universAAL.lddi.fs20.connect.FS20Listener$1 2
org.universAAL.lddi.fs20.devicemodel.FS20Device 1
org.universAAL.lddi.fs20.server.Activator 2
org.universAAL.lddi.fs20.server.DeviceReader 3

org.universAAL.lddi.fs20.connect.FHZ1000PC

Bug Category Details Line Priority
Bitwise add of signed byte value computed in org.universAAL.lddi.fs20.connect.FHZ1000PC.deviceEvent() CORRECTNESS BIT_ADD_OF_SIGNED_BYTE 426 Medium
The method name org.universAAL.lddi.fs20.connect.FHZ1000PC.StringFS20ToInt(String) doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 521 Medium
new org.universAAL.lddi.fs20.connect.FHZ1000PC(String) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 362 Medium
org.universAAL.lddi.fs20.connect.FHZ1000PC.binFS20ByteToString(int, int) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 507 Medium

org.universAAL.lddi.fs20.connect.FHZ1000PC$FHZ1000SerialDevice

Bug Category Details Line Priority
Switch statement found in org.universAAL.lddi.fs20.connect.FHZ1000PC$FHZ1000SerialDevice.serialEvent(SerialPortEvent) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 232 Medium
Unread field: org.universAAL.lddi.fs20.connect.FHZ1000PC$FHZ1000SerialDevice.MAX_WAIT_TIME_MS; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 164 Medium

org.universAAL.lddi.fs20.connect.FHZ1000PC$JD2XXFHZ1000Device

Bug Category Details Line Priority
Unread field: org.universAAL.lddi.fs20.connect.FHZ1000PC$JD2XXFHZ1000Device.DEVICE_DESCRIPTION; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 107 Medium

org.universAAL.lddi.fs20.connect.FS20Listener

Bug Category Details Line Priority
The method name org.universAAL.lddi.fs20.connect.FS20Listener.Init(FHZ1000PC, LogTracker) doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 144 Medium
org.universAAL.lddi.fs20.connect.FS20Listener.binFS20ByteToString(int, int) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 185 Medium
Switch statement found in org.universAAL.lddi.fs20.connect.FS20Listener.sendContextEvent(ServiceRegistration) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 77 Medium
Write to static field org.universAAL.lddi.fs20.connect.FS20Listener.context from instance method new org.universAAL.lddi.fs20.connect.FS20Listener(BundleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 63 High
Write to static field org.universAAL.lddi.fs20.connect.FS20Listener.logger from instance method org.universAAL.lddi.fs20.connect.FS20Listener.Init(FHZ1000PC, LogTracker) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 144 High
Unused field: org.universAAL.lddi.fs20.connect.FS20Listener.port PERFORMANCE UUF_UNUSED_FIELD Medium

org.universAAL.lddi.fs20.connect.FS20Listener$1

Bug Category Details Line Priority
Primitive value is boxed then unboxed to perform primitive coercion in org.universAAL.lddi.fs20.connect.FS20Listener$1.fs20Event(FS20Event) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 155 Medium
org.universAAL.lddi.fs20.connect.FS20Listener$1.fs20Event(FS20Event) invokes inefficient new Byte(byte) constructor; use Byte.valueOf(byte) instead PERFORMANCE DM_NUMBER_CTOR 155 Medium

org.universAAL.lddi.fs20.devicemodel.FS20Device

Bug Category Details Line Priority
org.universAAL.lddi.fs20.devicemodel.FS20Device.write(String, String, Byte) explicitly invokes run on a thread (did you mean to start it instead?) MT_CORRECTNESS RU_INVOKE_RUN 192 High

org.universAAL.lddi.fs20.server.Activator

Bug Category Details Line Priority
Write to static field org.universAAL.lddi.fs20.server.Activator.connection from instance method org.universAAL.lddi.fs20.server.Activator.start(BundleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 71 Medium
Write to static field org.universAAL.lddi.fs20.server.Activator.context from instance method org.universAAL.lddi.fs20.server.Activator.start(BundleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 66 Medium

org.universAAL.lddi.fs20.server.DeviceReader

Bug Category Details Line Priority
Possible null pointer dereference in org.universAAL.lddi.fs20.server.DeviceReader.readDevices(BundleContext, FHZ1000PC) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 77 Medium
org.universAAL.lddi.fs20.server.DeviceReader.readDevices(BundleContext, FHZ1000PC) may fail to clean up java.io.InputStream on checked exception EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE 80 Medium
Exception is caught when Exception is not thrown in org.universAAL.lddi.fs20.server.DeviceReader.readDevices(BundleContext, FHZ1000PC) STYLE REC_CATCH_EXCEPTION 168 Medium